DATACMNS-899 - Fix recursion in ParameterizedTypeInformation.getMapValueType #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap types causes StackOverflowError. Prepare issue branch.
…lueType. Previously, calls to ParameterizedTypeInformation.getMapValueType caused an infinite recursion when invoked on a type information that was not a map type. This lead to a StackOverflowError. We now call the super method doGetMapValueType() instead of calling the entry super method getMapValueType() and return by that null in case the map value type is not resolvable.
odrotbohm
pushed a commit
that referenced
this pull request
Sep 1, 2016
…lueType(). Previously, calls to ParameterizedTypeInformation.getMapValueType() caused an infinite recursion when invoked on a type information that was not a map type. This lead to a StackOverflowError. We now call the super method doGetMapValueType() instead of calling the entry super method getMapValueType() and return by that null in case the map value type is not resolvable. Original pull request: #176.
odrotbohm
pushed a commit
that referenced
this pull request
Sep 1, 2016
…lueType(). Previously, calls to ParameterizedTypeInformation.getMapValueType() caused an infinite recursion when invoked on a type information that was not a map type. This lead to a StackOverflowError. We now call the super method doGetMapValueType() instead of calling the entry super method getMapValueType() and return by that null in case the map value type is not resolvable. Original pull request: #176.
odrotbohm
pushed a commit
that referenced
this pull request
Sep 1, 2016
…lueType(). Previously, calls to ParameterizedTypeInformation.getMapValueType() caused an infinite recursion when invoked on a type information that was not a map type. This lead to a StackOverflowError. We now call the super method doGetMapValueType() instead of calling the entry super method getMapValueType() and return by that null in case the map value type is not resolvable. Original pull request: #176.
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
Make call to sort() before setting on builder.sources(). fixes spring-projectsgh-176
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
Make call to sort() before setting on builder.sources(). fixes spring-projectsgh-176 (cherry picked from commit 6dc35d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, calls to
ParameterizedTypeInformation#getMapValueTypecaused an infinite recursion when invoked on a type information that was not a map type. This lead to aStackOverflowError.We now call the super method
doGetMapValueType()instead of calling the entry super methodgetMapValueType()and return by thatnullin case the map value type is not resolvable.Related ticket: DATACMNS-899