Skip to content

Update documentation for repository Pageable and Sort arguments #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update documentation for repository Pageable and Sort arguments #2574

wants to merge 1 commit into from

Conversation

DiegoKrupitza
Copy link
Contributor

As mentioned in spring-projects/spring-data-jpa#2464 QueryByExampleExecutor#findAll(Example<S> example, Pageable pageable) should not accept null values since there is Pageable.unpaged(). Furthermore, the same applies to PagingAndSortingRepository#findAll(Pageable pageable).

Related tickets spring-projects/spring-data-jpa/issues/2464
Closes spring-projects/spring-data-jpa/issues/2464

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@DiegoKrupitza
Removed outdated null acceptance for Pageable.
30ca569 
As mentioned in spring-projects/spring-data-jpa#2464 `QueryByExampleExecutor#findAll(Example<S> example, Pageable pageable)` should not accept null values since there is `Pageable.unpaged()`. Furthermore, the same applies to `PagingAndSortingRepository#findAll(Pageable pageable)`.

Related tickets spring-projects/spring-data-jpa/issues/2464
Closes spring-projects/spring-data-jpa/issues/2464
@DiegoKrupitza DiegoKrupitza mentioned this pull request Mar 15, 2022
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 16, 2022
@mp911de mp911de self-assigned this Mar 18, 2022
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 18, 2022
@mp911de mp911de added this to the 2.5.10 (2021.0.10) milestone Mar 18, 2022
@mp911de mp911de changed the title Removed outdated null acceptance for Pageable. Update documentation for repository Pageable and Sort arguments Mar 18, 2022
mp911de pushed a commit that referenced this pull request Mar 18, 2022
@DiegoKrupitza @mp911de
Update documentation for repository Pageable and Sort arguments.
1ea8d09 
Replace outdated `null` acceptance for `Pageable` with `Pageable.unpaged()`
 `QueryByExampleExecutor#findAll(Example<S> example, Pageable pageable)` should does not accept null values since there is `Pageable.unpaged()`. Furthermore, the same applies to `PagingAndSortingRepository#findAll(Pageable pageable)`.

Related ticket: spring-projects/spring-data-jpa/issues/2464
Closes #2574
mp911de added a commit that referenced this pull request Mar 18, 2022
@mp911de
Polishing.
c73c0bf 
Consistent wording for pageable and sort arguments.

See #2574
@mp911de mp911de closed this in 43bba35 Mar 18, 2022
mp911de added a commit that referenced this pull request Mar 18, 2022
@mp911de
Polishing.
b6b1ec9 
Consistent wording for pageable and sort arguments.

See #2574
@mp911de
Copy link
Member

mp911de commented Mar 18, 2022

Thank you for your contribution. That's merged, polished, and backported now.

mp911de pushed a commit that referenced this pull request Mar 18, 2022
@DiegoKrupitza @mp911de
Update documentation for repository Pageable and Sort arguments.
95dd775 
Replace outdated `null` acceptance for `Pageable` with `Pageable.unpaged()`
 `QueryByExampleExecutor#findAll(Example<S> example, Pageable pageable)` should does not accept null values since there is `Pageable.unpaged()`. Furthermore, the same applies to `PagingAndSortingRepository#findAll(Pageable pageable)`.

Related ticket: spring-projects/spring-data-jpa/issues/2464
Closes #2574
mp911de added a commit that referenced this pull request Mar 18, 2022
@mp911de
Polishing.
9866df8 
Consistent wording for pageable and sort arguments.

See #2574
mp911de pushed a commit that referenced this pull request Mar 18, 2022
@DiegoKrupitza @mp911de
Update documentation for repository Pageable and Sort arguments.
35297df 
Replace outdated `null` acceptance for `Pageable` with `Pageable.unpaged()`
 `QueryByExampleExecutor#findAll(Example<S> example, Pageable pageable)` should does not accept null values since there is `Pageable.unpaged()`. Furthermore, the same applies to `PagingAndSortingRepository#findAll(Pageable pageable)`.

Related ticket: spring-projects/spring-data-jpa/issues/2464
Closes #2574
mp911de added a commit that referenced this pull request Mar 18, 2022
@mp911de
Polishing.
7f0846f 
Consistent wording for pageable and sort arguments.

See #2574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.5.10 (2021.0.10)
Development

Successfully merging this pull request may close these issues.

findAll(Example<S> example, Pageable pageable) should accept null.
3 participants
@DiegoKrupitza @mp911de @spring-projects-issues