Skip to content

add couchbaseJsonValueModule bean to AbstractCouchbaseConfiguration #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikereiche opened this issue Apr 22, 2021 · 1 comment · Fixed by #1132
Closed

add couchbaseJsonValueModule bean to AbstractCouchbaseConfiguration #1130

mikereiche opened this issue Apr 22, 2021 · 1 comment · Fixed by #1132
Labels
type: bug A general bug

Comments

@mikereiche
Copy link
Collaborator

mikereiche commented Apr 22, 2021 •
edited
Loading

https://forums.couchbase.com/t/setting-json-deserialisation-features-in-java-sdk-3/30215/6

We Could change contentAsObject() to always use JacksonTransformers.bytesToJsonObject() so it doesn't depend on the user registering the correct module. What do you think?
Should also add another preflight check and fail if JsonValueModule isn't registered.
@mikereiche mikereiche added the type: bug A general bug label Apr 22, 2021
@mikereiche
Copy link
Collaborator Author

This is a "feature" but I've marked it as a bug a as it really should have been like that in the first place.

@mikereiche mikereiche changed the title contentAsObject() to always use JacksonTransformers.bytesToJsonObject() so it doesn't depend on the user registering the correct module add couchbaseJsonValueModel bean to AbstractCouchbaseConfiguration Apr 22, 2021
@dnault dnault changed the title add couchbaseJsonValueModel bean to AbstractCouchbaseConfiguration add couchbaseJsonValueModule bean to AbstractCouchbaseConfiguration Apr 22, 2021
mikereiche added a commit that referenced this issue Apr 23, 2021
@mikereiche
Expose ObjectMapper used by JsonSerializer
869c0ab 
Closes #1130.
@mikereiche mikereiche mentioned this issue Apr 23, 2021
Merged
5 tasks
mikereiche added a commit that referenced this issue Apr 26, 2021
@mikereiche
Expose ObjectMapper used by JsonSerializer
4b121c0 
Closes #1130.
mikereiche added a commit that referenced this issue May 5, 2021
@mikereiche
Expose ObjectMapper used by JsonSerializer (#1132)
a806631 
Closes #1130.

Co-authored-by: mikereiche <[email protected]>
mikereiche added a commit that referenced this issue Aug 9, 2021
@mikereiche
Expose ObjectMapper used by JsonSerializer (#1132)
0930e5b 
Closes #1130.

Co-authored-by: mikereiche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose ObjectMapper used by JsonSerializer spring-projects/spring-data-couchbase
1 participant
@mikereiche