Skip to content

Add rescore functionality #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
peermuellerxw opened this issue Feb 11, 2021 · 2 comments · Fixed by #1688
Closed

Add rescore functionality #1686

peermuellerxw opened this issue Feb 11, 2021 · 2 comments · Fixed by #1688
Labels
type: enhancement A general enhancement

Comments

@peermuellerxw
Copy link
Contributor

Hi, wanted to ask if there is any reason why the rescore functionality is not implemented for NativeSearchQuery? Would you like a PR?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 11, 2021
@sothawo
Copy link
Collaborator

sothawo commented Feb 11, 2021

Probably because it never was requested as a feature.

If you want to implement it, take care that this must beimplemented in all the clients/operations (transport, rest, reactive).

It probably makes sense to add the possibility for adding rescore queries to all Query implementations, not only NativeSearchQuery

@sothawo sothawo added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 11, 2021
peermuellerxw pushed a commit to peermuellerxw/spring-data-elasticsearch that referenced this issue Feb 11, 2021
Add Rescore functionality
130cf63 
Closes spring-projects#1686
@peermuellerxw peermuellerxw mentioned this issue Feb 11, 2021
Merged
@peermuellerxw
Copy link
Contributor Author

Hi @sothawo,
thanks for your quick reply. However, I do not really understand your concerns. As far as I understand the type of query and the client that is used for the connection do not affect each other. Meaning, that the NativeSearchQuery can be used for transport/rest/reactive clients...

I opened a PR. Reviews are welcome.

Could also add a rescorer annotation if wanted...

sothawo pushed a commit that referenced this issue Mar 13, 2021
@peermuellerxw
Add Rescore functionality.
b289d5f 
Original Pull Request #1688
Closes #1686
@sothawo sothawo changed the title Add rescore functionality to NativeSearchQuery Add rescore functionality Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Rescore functionality peermuellerxw/spring-data-elasticsearch
3 participants
@sothawo @spring-projects-issues @peermuellerxw