Skip to content

Add support for GZIP compression requests using ClientConfiguration #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yoni10 opened this issue Apr 28, 2022 · 0 comments · Fixed by #2237
Closed

Add support for GZIP compression requests using ClientConfiguration #2149

yoni10 opened this issue Apr 28, 2022 · 0 comments · Fixed by #2237
Labels
type: enhancement A general enhancement

Comments

@yoni10
Copy link

yoni10 commented Apr 28, 2022

The RestClientBuilder class
org.elasticsearch.client.RestClientBuilder has already an property compressionEnabled that enabled compressed gzip requests to Elastic.

The RestClients class
org.springframework.data.elasticsearch.client.RestClients has method called 'create' that accept ClientConfiguration object and put it into new RestClientBuilder class.
In order to use compression in request we need the agility to pass into the ClientConfiguration object the property of compressionEnabled.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 28, 2022
@sothawo sothawo added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 29, 2022
sothawo added a commit to sothawo/spring-data-elasticsearch that referenced this issue Jul 23, 2022
@sothawo
Refine the configuration callbacks in the ClientConfiguration.
6a9015c 
Closes spring-projects#2149
@sothawo sothawo mentioned this issue Jul 23, 2022
Merged
sothawo added a commit that referenced this issue Jul 23, 2022
@sothawo
Refine the configuration callbacks in the ClientConfiguration.
1c31a31 
Original Pull Request #2237
Closes #2149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine the configuration callbacks in the ClientConfiguration. sothawo/spring-data-elasticsearch
3 participants
@sothawo @yoni10 @spring-projects-issues