Skip to content

Commit 9299776

Browse files
Nugsodrotbohm
authored andcommitted
DATAJPA-834 - Use less common bean name for EntityManagerBeanDefinitionRegistrarPostProcessor.
Replacing bean name "foo" with more meaningful value injected via constant as a bean probably shouldn't have "foo" as its name when everything else has meaningful values defined in constants. Renamed bean and extracted constant alongside others referenced within the file. Original pull request: #159.
1 parent 56c7afd commit 9299776

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/main/java/org/springframework/data/jpa/repository/config/BeanDefinitionNames.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,5 @@ interface BeanDefinitionNames {
2525

2626
public static final String JPA_MAPPING_CONTEXT_BEAN_NAME = "jpaMappingContext";
2727
public static final String JPA_CONTEXT_BEAN_NAME = "jpaContext";
28+
public static final String EM_BEAN_DEFINITION_REGISTRAR_POST_PROCESSOR_BEAN_NAME = "emBeanDefinitionRegistrarPostProcessor";
2829
}

src/main/java/org/springframework/data/jpa/repository/config/JpaRepositoryConfigExtension.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ public void registerBeansForRoot(BeanDefinitionRegistry registry, RepositoryConf
164164
Object source = config.getSource();
165165

166166
registerIfNotAlreadyRegistered(new RootBeanDefinition(EntityManagerBeanDefinitionRegistrarPostProcessor.class),
167-
registry, "foo", source);
167+
registry, EM_BEAN_DEFINITION_REGISTRAR_POST_PROCESSOR_BEAN_NAME, source);
168168

169169
registerIfNotAlreadyRegistered(new RootBeanDefinition(JpaMetamodelMappingContextFactoryBean.class), registry,
170170
JPA_MAPPING_CONTEXT_BEAN_NAME, source);

0 commit comments

Comments
 (0)