Replacing bean name "foo" with more meaningful value #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stant A bean probably shouldn't have "foo" as its name when everything else has meaningful values defined in constants. Renamed bean and extracted constant alongside others referenced within the file.
Replacing bean name "foo" with more meaningful value
odrotbohm
pushed a commit
that referenced
this pull request
Dec 12, 2015
…onRegistrarPostProcessor. Replacing bean name "foo" with more meaningful value injected via constant as a bean probably shouldn't have "foo" as its name when everything else has meaningful values defined in constants. Renamed bean and extracted constant alongside others referenced within the file. Original pull request: #159.
odrotbohm
added a commit
that referenced
this pull request
Dec 12, 2015
Updated copyright date range and added author. Original pull request: #159.
odrotbohm
pushed a commit
that referenced
this pull request
Dec 12, 2015
…onRegistrarPostProcessor. Replacing bean name "foo" with more meaningful value injected via constant as a bean probably shouldn't have "foo" as its name when everything else has meaningful values defined in constants. Renamed bean and extracted constant alongside others referenced within the file. Original pull request: #159.
odrotbohm
added a commit
that referenced
this pull request
Dec 12, 2015
Updated copyright date range and added author. Original pull request: #159.
odrotbohm
pushed a commit
that referenced
this pull request
Dec 12, 2015
…onRegistrarPostProcessor. Replacing bean name "foo" with more meaningful value injected via constant as a bean probably shouldn't have "foo" as its name when everything else has meaningful values defined in constants. Renamed bean and extracted constant alongside others referenced within the file. Original pull request: #159.
odrotbohm
added a commit
that referenced
this pull request
Dec 12, 2015
Updated copyright date range and added author. Original pull request: #159.
|
That's merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happened across this one by accident. Just a general piece of housekeeping - a bean probably should have a meaningful name!