Skip to content

Fixes * bug in createCountQueryFor. #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixes * bug in createCountQueryFor. #2514

wants to merge 1 commit into from

Conversation

DiegoKrupitza
Copy link
Contributor

In commit 3e64d9a a bug got introduced that uses the next symbol after the table name for the count function. With this commit this should be now resolved. The count query will use * when there is no alias present nor a variable.

Related tickets #2177, #2260, #2511

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@DiegoKrupitza
Fixes * bug in createCountQueryFor.
6f8170b 
In commit 3e64d9a a bug got introduced that uses the next symbol after the table name for the count function. With this commit this should be now resolved. The count query will use `*` when there is no alias present nor a variable.

Related tickets spring-projects#2177, spring-projects#2260, spring-projects#2511
@DiegoKrupitza DiegoKrupitza mentioned this pull request Apr 28, 2022
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 28, 2022
@gregturn gregturn added this to the 3.0 M4 (2022.0.0) milestone May 4, 2022
@gregturn gregturn added type: regression A regression from a previous release type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 4, 2022
@gregturn gregturn self-assigned this May 4, 2022
gregturn added a commit that referenced this pull request May 4, 2022
@gregturn
Polishing.
1f2e4a1 
See #2514.
@gregturn gregturn closed this May 4, 2022
@gregturn
Copy link
Contributor

gregturn commented May 4, 2022

Thanks @DiegoKrupitza!

gregturn added a commit that referenced this pull request May 4, 2022
@gregturn
Polishing.
e81c54b 
See #2514.
@gregturn
Copy link
Contributor

gregturn commented May 4, 2022

Backported to 2.7.x.

gregturn added a commit that referenced this pull request May 4, 2022
@gregturn
Polishing.
e5d0841 
See #2514.
@gregturn
Copy link
Contributor

gregturn commented May 4, 2022

Backported to 2.6.x.

gregturn added a commit that referenced this pull request May 4, 2022
@gregturn
Polishing.
7d61ab2 
See #2514.
@gregturn
Copy link
Contributor

gregturn commented May 4, 2022 •
edited
Loading

Backported to 2.5.x.

@gregturn gregturn mentioned this pull request May 4, 2022
Closed
@lavanya2290
Copy link

which version of 2.5.x is it backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregturn gregturn

Labels
type: bug A general bug type: regression A regression from a previous release
Projects
None yet
Milestone
3.0 M4 (2022.0.0)
Development

Successfully merging this pull request may close these issues.
4 participants
@DiegoKrupitza @gregturn @lavanya2290 @spring-projects-issues