DATAJPA-1446 - Clear JpaMetamodel CACHE when application context is c… #301
Conversation
| @@ -109,6 +112,11 @@ public boolean hasPersistentEntityFor(Class<?> type) { | |||
| return super.hasPersistentEntityFor(type) || models.isMetamodelManagedType(type); | |||
| } | |||
|
|
|||
| @EventListener | |||
There was a problem hiding this comment.
Spring library components are not supposed to use @EventListener (it's a choice for application developers, but it's really inefficient, so not a good idea for libraries). You could put this in a @PreDestroy though, I expect (or DisposableBean probably better).
There was a problem hiding this comment.
Thanks for the review! I just updated my PR to use a DisposableBean instead.
There was a problem hiding this comment.
Well, implementing DisposableBean in class JpaMetamodelMappingContext was not triggering anything when application context is closed. Since JpaMetamodelMappingContextFactoryBean already implements DisposableBean, I decided to update my PR to clean the cache here instead.
This time, the cache is cleaned when applicationContext is closed.
Nowheresly
force-pushed
the
DATAJPA-1446
branch
2 times, most recently
from
0eeb77f to
d360807
Compare
Nowheresly
force-pushed
the
DATAJPA-1446
branch
from
d360807 to
1d4c96e
Compare
…losed. We now register a dedicated Spring Bean to wipe the static cache in JpaMetamodel to avoid memory from leaking in scenarios where ApplicationContexts are started and closed very often (e.g. integration tests). Heavily inspired by the work Sylvere Richard (@Nowheresly) has done in #301 but the key responsibility of wiping moved away from the MappingCOntext implementation. Original pull request #301.
…losed. We now register a dedicated Spring Bean to wipe the static cache in JpaMetamodel to avoid memory from leaking in scenarios where ApplicationContexts are started and closed very often (e.g. integration tests). Heavily inspired by the work Sylvere Richard (@Nowheresly) has done in #301 but the key responsibility of wiping moved away from the MappingCOntext implementation. Original pull request #301.
…losed. We now register a dedicated Spring Bean to wipe the static cache in JpaMetamodel to avoid memory from leaking in scenarios where ApplicationContexts are started and closed very often (e.g. integration tests). Heavily inspired by the work Sylvere Richard (@Nowheresly) has done in #301 but the key responsibility of wiping moved away from the MappingCOntext implementation. Original pull request #301.
|
That's complete. I took a slightly different approach, see the ticket comment for details. Kept the credits in the classes around and attributed you in the commit message. |
…losed. We now register a dedicated Spring Bean to wipe the static cache in JpaMetamodel to avoid memory from leaking in scenarios where ApplicationContexts are started and closed very often (e.g. integration tests). Heavily inspired by the work Sylvere Richard (@Nowheresly) has done in spring-projects#301 but the key responsibility of wiping moved away from the MappingCOntext implementation. Original pull request spring-projects#301.
…losed.