Skip to content

Package private visibility of ConversionContext prevents subclassing of MappingMongoConverter #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
H3adcra5h opened this issue Mar 24, 2023 · 2 comments
Closed

Package private visibility of ConversionContext prevents subclassing of MappingMongoConverter #4345

H3adcra5h opened this issue Mar 24, 2023 · 2 comments
Assignees
@christophstrobl
Labels
type: regression A regression from a previous release
Milestone
3.4.11 (2021.2.11)

Comments

@H3adcra5h
Copy link

We changed from Version 3.3.3 to 3.4.8 by updating Spring Boot from 2.6.6 to 2.7.9.

The visibility of class ConversionContext changed from protected to package private.
Creating a subclass of MappingMongoConverter and overwrite the protected method readDocument is no longer possible if the subclass package is outside of org.springframework.data.mongodb.core.convert. Same with other protected methods that use ConversionContext as parameter.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 24, 2023
@christophstrobl
Copy link
Member

@H3adcra5h thanks for reporting - my bad. sorry for the inconvenience - we'll get this fixed.

@christophstrobl christophstrobl self-assigned this Mar 24, 2023
@christophstrobl christophstrobl added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 24, 2023
christophstrobl added a commit that referenced this issue Mar 24, 2023
@christophstrobl
Update visibility of ConversionContext.
f157560 
The ConversionContext should not be package private due to its usage in protected method signatures.

Closes: #4345
christophstrobl added a commit that referenced this issue Mar 24, 2023
@christophstrobl
Update visibility of ConversionContext.
c8c3136 
The ConversionContext should not be package private due to its usage in protected method signatures.

Closes: #4345
@christophstrobl christophstrobl added this to the 3.4.11 (2021.2.11) milestone Mar 24, 2023
@H3adcra5h
Copy link
Author

Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
3.4.11 (2021.2.11)
Development

No branches or pull requests
3 participants
@christophstrobl @spring-projects-issues @H3adcra5h