DATAMONGO-1005 - Improve cycle-detection for DbRef's. #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasdarimont
pushed a commit
that referenced
this pull request
Jul 24, 2014
Introduced ObjectPath that collects the target objects while converting a DBObject to a domain object. If we detect that a potentially nested DBRef points to an object that is already under construction we simply return a reference to that object in order to avoid StackOverFlowErrors. Original pull request: #209.
|
Generally looks good to me. A few observations:
|
|
I applied most of your suggestions, but I still create ObjectPath instances since I it is intended to be used as an immutable type. |
added 3 commits
August 5, 2014 15:08
Prepare issue branch.
Introduced ObjectPath that collects the target objects while converting a DBObject to a domain object. If we detect that a potentially nested DBRef points to an object that is already under construction we simply return a reference to that object in order to avoid StackOverFlowErrors. Original pull request: #209.
Made ObjectPath a more ubiquitous type in the nested method calls to avoid the extracting and rewrapping of the current object. Introduced ObjectPathItem that captures the object, idValue and collection tuple to avoid performing the property lookup multiple times.
thomasdarimont
pushed a commit
that referenced
this pull request
Aug 12, 2014
Introduced ObjectPath that collects the target objects while converting a DBObject to a domain object. If we detect that a potentially nested DBRef points to an object that is already under construction we simply return a reference to that object in order to avoid StackOverFlowErrors. Original pull request: #209.
odrotbohm
added a commit
that referenced
this pull request
Aug 12, 2014
Simplified implementation of ObjectPath to use a static root instance and hand the path further down until final resolution in MappingMongoConverter.readValue(…). This removes a bit of boxing and unboxing code both in ObjectPath and the converter. Introduced ObjectPath.getPathItem(…) to internalize the iteration to find a potentially already resolved object. Renamed parameters and fields of type ObjectPath to path consistently. Removed obsolete method in MappingMongoConverter. Original pull request: #209.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced ObjectPath that collects target objects along the current property path while converting a DBObject to a domain object. If we detect that a potentially nested DBRef points to an object that is already under construction we simply return a reference to that object in order to avoid StackOverFlowErrors otherwise we resolve the DBRef.