DATAMONGO-1289 - NullPointerException when saving an object with no "id" field or @Id annotation. #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id" field or @id annotation. Prepare issue branch.
Add tests that show it works using MongoTemplate but fails for the repository.
We now use RepositoryMetdata#getIdType to provide a fallback id type once the entity information does not hold an id property which is perfectly valid for mongodb. This is a bit more sophisticated than just default to ObjectId.
christophstrobl
added a commit
that referenced
this pull request
Dec 16, 2015
…ifier type derived from repository declaration. We now use RepositoryMetdata.getIdType() to provide a fallback identifier type in case the entity information does not hold an id property which is perfectly valid for MongoDB. Original pull request: #333.
odrotbohm
added a commit
that referenced
this pull request
Dec 16, 2015
Some additional JavaDoc and comment removal. Original pull request: #333.
christophstrobl
added a commit
that referenced
this pull request
Dec 16, 2015
…ifier type derived from repository declaration. We now use RepositoryMetdata.getIdType() to provide a fallback identifier type in case the entity information does not hold an id property which is perfectly valid for MongoDB. Original pull request: #333.
odrotbohm
added a commit
that referenced
this pull request
Dec 16, 2015
Some additional JavaDoc and comment removal. Original pull request: #333.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! DO NOT MERGE !!! Opened for discussion.
We now use
RepositoryMetdata.getIdType()to provide a fallback id type once theEntityInformationdoes not hold an id property which is perfectly valid for mongodb. This is a bit more sophisticated than just defaulting toObjectIdbut requires us to use theRepositoryMetadatawhich is not available when callingRepositoryFactorySupport.getEntityInformation.Having that said we might want to think about changing the method signature of
getEntityInformationso it takesRepositoryMetdatawich would allow us to access the required data.