Call to id instead of elementId for assigned ids

[meistermeier]

Given the right Cypher dialect for NEO4J_5 was set, Spring Data Neo4j will still produce id calling queries and it might not be needed to do so.

UNWIND $__relationships__ AS relationship WITH relationship
MATCH (startNode:`Game`) WHERE startNode.appId = relationship.fromId
MATCH (endNode) WHERE **id(endNode)** = relationship.toId 
MERGE (startNode)-[relProps:`CATEGORIES`]->(endNode) RETURN elementId(relProps) AS __elementId__

For the parameters this line

spring-data-neo4j/src/main/java/org/springframework/data/neo4j/core/TemplateSupport.java

Line 430 in 52535f3

return !targetEntity.isUsingDeprecatedInternalId() && targetEntity.isUsingInternalIds() && rendererRendersElementId(renderer);

makes elementIds for assigned ids not usable in generated queries for relationships.
The statement targetEntity.isUsingInternalIds() resolves to false and will always trigger the id fallback for

spring-data-neo4j/src/main/java/org/springframework/data/neo4j/core/Neo4jTemplate.java

Line 828 in 52535f3

relatedInternalId = TemplateSupport.rendererCanUseElementIdIfPresent(renderer, targetEntity) ? savedEntity.elementId() : savedEntity.id();

The query generator side

spring-data-neo4j/src/main/java/org/springframework/data/neo4j/core/mapping/CypherGenerator.java

Line 530 in 52535f3

.where(getEndNodeIdFunction((Neo4jPersistentEntity<?>) relationship.getTarget()).apply(endNode).isEqualTo(Cypher.property(row, Constants.TO_ID_PARAMETER_NAME)))

or to be more precise the logic inside

spring-data-neo4j/src/main/java/org/springframework/data/neo4j/core/mapping/CypherGenerator.java

Lines 479 to 491 in 52535f3

	private static Function<Node, Expression> getEndNodeIdFunction(@Nullable Neo4jPersistentEntity<?> entity) {
	Function<Node, Expression> startNodeIdFunction;
	if (entity == null) {
	return Functions::elementId;
	}
	if (!entity.isUsingDeprecatedInternalId() && entity.isUsingInternalIds()) {
	startNodeIdFunction = Functions::elementId;
	} else {
	startNodeIdFunction = Functions::id;
	}
	return startNodeIdFunction;
	}

has the same behaviour.

I don't know the reason why I decided to go this route and this needs some deeper analysis of why this is happening.

Thanks to @pbauerochse for reporting this.

[meistermeier]

Version for testing: 7.2.0-GH-2809-SNAPSHOT

  <repositories>
    <repository>
      <id>spring-milestones</id>
      <name>Spring Milestones</name>
      <url>https://repo.spring.io/milestone</url>
      <snapshots>
        <enabled>false</enabled>
      </snapshots>
    </repository>
    <repository>
      <id>spring-snapshots</id>
      <name>Spring Snapshots</name>
      <url>https://repo.spring.io/snapshot</url>
      <releases>
        <enabled>false</enabled>
      </releases>
    </repository>
  </repositories>

[pbauerochse]

Seems to be fixed with your snapshot version. Thanks Gerrit