Some spelling and grammar fixes. #2402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
michael-simons
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
Thank you so much @rlippolis That is an amazing and very diligent PR which I am happy to merge.
| @@ -148,8 +148,8 @@ module your.module { | |||
| exports your.domain; // <.> | |||
| } | |||
| ---- | |||
| <.> Spring Data Neo4j uses Spring Data Commons and it's reflective capabilities, so | |||
| you would need to open up your domain packages to `spring.core` at least. | |||
There was a problem hiding this comment.
@meistermeier How could you have missed this :D
michael-simons
added
type: documentation
michael-simons
pushed a commit
that referenced
this pull request
Oct 18, 2021
michael-simons
pushed a commit
that referenced
this pull request
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the Spring Data Neo4j documentation, I noticed a minor error and decided to create a PR to fix that. Then I noticed a few more spelling and grammar issues. This is by no means a complete proofreading of all the documentation as I am no English expert, but it at least fixes some of the low-hanging fruit.