Registration of columns for generated keys is now dialect dependent. #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous version the debugger of IntelliJ broke. See https://youtrack.jetbrains.com/issue/KTIJ-5659
Different R2DBC drivers expect generated keys when they are in camel case to be quoted or unquoted. This can now be controlled by implementing `Dialect.renderForGeneratedKeys`. Closes: #483
This allows to ignore tests without database available to be ignored, instead of failing with an error.
|
That's polished, merged and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different R2DBC drivers expect generated keys when they are in camel case to be quoted or unquoted.
This can now be controlled by implementing
Dialect.renderForGeneratedKeys.Also:
NoAvailableDatabasereturns dummy values instead of throwing exceptions. - This allows to ignore tests without database available to be ignored, instead of failing with an error.Closes: #483
Note: Implementations for SqlServer and Oracle aren't tested yet.