Add Range and Limit support to ZSetOperations.rangeByScoreWithScores #3145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the Range and Limit parameters to the rangeByScoreWithScores and reverseRangeByScoreWithScores methods in ZSetOperations interface. The implementation follows the same pattern already used for other methods like rangeByLex, providing a more flexible and consistent API for working with Redis sorted sets. New methods: - rangeByScoreWithScores(K key, Range<Double> range) - rangeByScoreWithScores(K key, Range<Double> range, Limit limit) - reverseRangeByScoreWithScores(K key, Range<Double> range) - reverseRangeByScoreWithScores(K key, Range<Double> range, Limit limit) Unit and integration tests added to verify functionality. Fixes spring-projects#3139 Related to spring-projects#796 and spring-projects#938 Signed-off-by: kssumin <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for the Range and Limit parameters to the rangeByScoreWithScores and reverseRangeByScoreWithScores methods in the ZSetOperations interface, enhancing flexibility and consistency with other methods in the API.
Description
The PR implements four new methods in the ZSetOperations interface:
rangeByScoreWithScores(K key, Range<Double> range)rangeByScoreWithScores(K key, Range<Double> range, Limit limit)reverseRangeByScoreWithScores(K key, Range<Double> range)reverseRangeByScoreWithScores(K key, Range<Double> range, Limit limit)This allows users to:
Motivation
Currently, rangeByScoreWithScores methods only accept double parameters for min/max scores, which limits flexibility for boundary conditions and special values like infinity. Using Range and Limit objects provides a more powerful and consistent API.
This enhancement was requested in issue #3139 and relates to older issues #796 and #938, where @mp911de indicated these methods should be added.
Testing
Added both unit tests in DefaultZSetOperationsUnitTests and integration tests in DefaultZSetOperationsIntegrationTests to verify correct functionality.
The tests validate:
Range parameter handling with various boundary conditions
Limit parameter for pagination
Correct ordering of results for reverse operations
You have read the Spring Data contribution guidelines.
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).