Skip to content

Handle top-level collections without entity lookup in MappingRedisConverter #2168 #3146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Handle top-level collections without entity lookup in MappingRedisConverter #2168 #3146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a95f58
Skip metadata lookup for top-level collections in MappingRedisConverter
Leehyoungwoo May 9, 2025
c3dd7a1
Annotate writePlainList test with GH-2168 and remove Java-8 restriction
Leehyoungwoo May 9, 2025
43c473c
Add author annotation to headers of modified classes
Leehyoungwoo May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/org/springframework/data/redis/core/convert/MappingRedisConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
* @author Greg Turnquist
* @author Mark Paluch
* @author Golam Mazid Sajib
* @author Leehyoungwoo
* @since 1.7
*/
public class MappingRedisConverter implements RedisConverter, InitializingBean {
Expand Down Expand Up @@ -404,6 +405,17 @@ public void write(Object source, RedisData sink) {
return;
}

if (source instanceof Collection) {
writeCollection(
sink.getKeyspace(),
"",
(List<?>) source,
TypeInformation.of(Object.class),
sink
);
return;
}

RedisPersistentEntity<?> entity = mappingContext.getPersistentEntity(source.getClass());

if (!customConversions.hasCustomWriteTarget(source.getClass())) {
Expand Down
5 changes: 2 additions & 3 deletions ...test/java/org/springframework/data/redis/core/convert/MappingRedisConverterUnitTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,9 +1997,8 @@ void readGenericEntity() {
assertThat(generic.entity.name).isEqualTo("hello");
}

@Test // DATAREDIS-1175
@EnabledOnJre(JRE.JAVA_8)
// FIXME: https://github.com/spring-projects/spring-data-redis/issues/2168
@Test // GH-2168
// @EnabledOnJre(JRE.JAVA_8)
void writePlainList() {

List<Object> source = Arrays.asList("Hello", "stream", "message", 100L);
Expand Down