Skip to content

JdbcAggregateTemplate doesn't need the domainType as an explicit argument. #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
schauder opened this issue Aug 25, 2022 · 0 comments
Closed

JdbcAggregateTemplate doesn't need the domainType as an explicit argument. #1315

schauder opened this issue Aug 25, 2022 · 0 comments
Labels
type: enhancement A general enhancement
Milestone
3.0 RC1 (2022.0.0)

Comments

@schauder
Copy link
Contributor

On a general level, why do we define delete(T aggregateRoot, Class<T> domainType) (i.e. passing on the domain type) instead of determining the domain type from the aggregateRoot object? Other methods follow a similar design.

Originally posted by @mp911de in #1314 (comment)
schauder added a commit that referenced this issue Aug 29, 2022
@schauder
Drop superfluous class argument from delete methods in JdbcAggregateT…
9d16959 
…emplate.

Closes #1315
@schauder schauder mentioned this issue Aug 29, 2022
Closed
mp911de pushed a commit that referenced this issue Oct 5, 2022
@schauder @mp911de
Polishing.
fb2bead 
See: #1315
Original pull request: #1324.
@mp911de mp911de closed this as completed in a3d334d Oct 5, 2022
mp911de added a commit that referenced this issue Oct 5, 2022
@mp911de
Polishing.
7475fd4 
Use consistent method and argument names for newly introduced methods. Reorder and group template API methods to keep related methods together.

See: #1315
Original pull request: #1324.
mp911de added a commit that referenced this issue Oct 5, 2022
@mp911de
Deprecate mutability of DelegatingDataAccessStrategy.
c38b3c4 
See: #1315
Original pull request: #1324.
@mp911de mp911de added the type: enhancement A general enhancement label Oct 5, 2022
@mp911de mp911de added this to the 3.0 RC1 (2022.0.0) milestone Oct 5, 2022
schauder added a commit that referenced this issue Oct 5, 2022
@schauder
Polishing.
01e98dc 
See: #1315
Original pull request: #1324.
schauder added a commit that referenced this issue Oct 5, 2022
@schauder
Drop superfluous class argument from delete methods in `JdbcAggregate…
aef1e34 
…Template`.

Closes: #1315
Original pull request: #1324.
schauder pushed a commit that referenced this issue Oct 5, 2022
@mp911de @schauder
Polishing.
26c5c5d 
Use consistent method and argument names for newly introduced methods. Reorder and group template API methods to keep related methods together.

See: #1315
Original pull request: #1324.
schauder pushed a commit that referenced this issue Oct 5, 2022
@mp911de @schauder
Deprecate mutability of DelegatingDataAccessStrategy.
76ea47a 
See: #1315
Original pull request: #1324.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0 RC1 (2022.0.0)
2 participants
@schauder @mp911de