Skip to content

Introduce ResourcePatternHint#toRegex #28620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sdeleuze opened this issue Jun 14, 2022 · 0 comments
Closed

Introduce ResourcePatternHint#toRegex #28620

sdeleuze opened this issue Jun 14, 2022 · 0 comments
Assignees
@sdeleuze
Labels
theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
6.0.0-M5

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Jun 14, 2022 •
edited
Loading

This change is done for several reasons:

  • Move the logic where it is documented.
  • Test it with ResourcePatternHintTests.
  • Allow RuntimeHintsPredicates to leverage this logic.
@sdeleuze sdeleuze added type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Jun 14, 2022
@sdeleuze sdeleuze added this to the 6.0.0-M5 milestone Jun 14, 2022
@sdeleuze sdeleuze self-assigned this Jun 14, 2022
bclozel added a commit that referenced this issue Jun 14, 2022
@bclozel
Polish ResourceHintsPredicates
7f7f458 
As of #28620, `ResourcePatternHint` exposes its `toRegex` method.
The predicates should use it directly and mirror the exact matching
behavior.

See gh-28555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M5
Development

No branches or pull requests
1 participant
@sdeleuze