Skip to content

Add ConstantReadableJavaField caching in ConstantFieldSubstitutionProcessor #29250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sdeleuze opened this issue Oct 4, 2022 · 2 comments
Closed

Add ConstantReadableJavaField caching in ConstantFieldSubstitutionProcessor #29250

sdeleuze opened this issue Oct 4, 2022 · 2 comments
Assignees
@sdeleuze
Labels
theme: aot An issue related to Ahead-of-time processing type: bug A general bug
Milestone
6.0.0-RC1

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Oct 4, 2022

As discussed in oracle/graal#5098, GraalVM expects a unique instance of ConstantReadableJavaField per field, so we need to use proper caching.
@sdeleuze sdeleuze added type: bug A general bug theme: aot An issue related to Ahead-of-time processing labels Oct 4, 2022
@sdeleuze sdeleuze added this to the 6.0.0-RC1 milestone Oct 4, 2022
@sdeleuze sdeleuze self-assigned this Oct 4, 2022
@sdeleuze sdeleuze mentioned this issue Oct 4, 2022
Closed
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Oct 4, 2022
@sdeleuze
Make ConstantFieldSubstitutionProcessor thread-safe
5c447bb 
See spring-projectsgh-29250
@nhandev552
Copy link

Why I don't see this code in Spring Framework 6.0.3?

I also got issue in version 6.0.3: oracle/graal#5098

@sbrannen
Copy link
Member

sbrannen commented Jan 8, 2023

Why I don't see this code in Spring Framework 6.0.3?

That code was superseded in commit 0889e47 by code introduced in conjunction with #29081.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
theme: aot An issue related to Ahead-of-time processing type: bug A general bug
Projects
None yet
Milestone
6.0.0-RC1
Development

No branches or pull requests
3 participants
@sbrannen @sdeleuze @nhandev552