Skip to content

Change keyvalue name to http.url in server observations #29254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bclozel opened this issue Oct 4, 2022 · 0 comments
Closed

Change keyvalue name to http.url in server observations #29254

bclozel opened this issue Oct 4, 2022 · 0 comments
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: enhancement A general enhancement
Milestone
6.0.0-RC1

Comments

@bclozel
Copy link
Member

bclozel commented Oct 4, 2022

The Observalibity filters for MVC and WebFlux both contribute a uri.expanded high cardinality key value for the actual request URL. Since this is a new key value, we should instead adopt a name consistent with the OTel spec such as http.url.
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement theme: observability An issue related to observability and tracing labels Oct 4, 2022
@bclozel bclozel added this to the 6.0.0-RC1 milestone Oct 4, 2022
@bclozel bclozel self-assigned this Oct 4, 2022
@bclozel bclozel closed this as completed in 486a1b6 Oct 5, 2022
bclozel added a commit that referenced this issue Oct 5, 2022
@bclozel
Provide full request URL for "http.url" keyvalue
681cf0d 
Prior to this commit, the Observation filter for Servlet applications
would only use the request pathInfo as an "http.url" high cardinality
keyvalue. This commit ensures that we're using the full request URL as a
value there.

This also polishes gh-29254.

Fixes gh-29257
See gh-29254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-RC1
Development

No branches or pull requests
1 participant
@bclozel