Skip to content

Extract forwarded header handling out of UriComponentsBuilder #30886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rstoyanchev opened this issue Jul 13, 2023 · 0 comments
Closed

Extract forwarded header handling out of UriComponentsBuilder #30886

rstoyanchev opened this issue Jul 13, 2023 · 0 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.1.0-M3

Comments

@rstoyanchev
Copy link
Contributor

The main purpose of UriComponentsBulider#fromHttpRequest is to apply forwarded headers to the URI of the current request, and allows re-use from Spring MVC and WebFlux. We should make that more explicit through a dedicated class.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Jul 13, 2023
@rstoyanchev rstoyanchev added this to the 6.1.0-M3 milestone Jul 13, 2023
@rstoyanchev rstoyanchev self-assigned this Jul 13, 2023
jhoeller added a commit that referenced this issue Jul 14, 2023
@jhoeller
Remove unused import
0d5a7db 
See gh-30886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M3
Development

No branches or pull requests
1 participant
@rstoyanchev