Added Basic Authorization for UrlResource #1822
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@x-x-z Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@x-x-z Thank you for signing the Contributor License Agreement! |
dreis2211
reviewed
May 10, 2018
| @@ -167,6 +169,12 @@ private URL getCleanedUrl(URL originalUrl, String originalPath) { | |||
| public InputStream getInputStream() throws IOException { | |||
| URLConnection con = this.url.openConnection(); | |||
| ResourceUtils.useCachesIfNecessary(con); | |||
|
|
|||
| if (this.url.getUserInfo() != null) { | |||
| String basicAuth = "Basic " + new String(Base64Utils.encode(url.getUserInfo().getBytes())); | |||
There was a problem hiding this comment.
What about using Base64Utils.encodeToString()?
There was a problem hiding this comment.
@dreis2211
Thank you for your comment.
I fixed it in "005911e"
|
👍 |
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
the
in: core
|
@x-x-z can you share how this is a fix for the issue you've linked? |
snicoll
added
the
status: waiting-for-feedback
snicoll
changed the title
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Aug 22, 2023
snicoll
added a commit
that referenced
this pull request
Aug 22, 2023
|
Sorry for the delay @x-x-z and thanks very much for making your first contribution to Spring Framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Basic Authorization for UrlResource.
This is fix for spring-projects/spring-boot#6138