Skip to content

Fix Javadoc for HttpHeaders.setContentLanguage() #23051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Javadoc for HttpHeaders.setContentLanguage() #23051

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented May 29, 2019

This PR changes set() to addAll() in Javadoc for HttpHeaders.setContentLanguage() as set() for the parameter types doesn't seem to exist and addAll() seems most suitable to the following description around available methods.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 29, 2019
@sdeleuze sdeleuze added this to the 5.1.8 milestone May 29, 2019
@sdeleuze sdeleuze removed the status: waiting-for-triage An issue we've not yet triaged or decided on label May 29, 2019
@sdeleuze sdeleuze self-assigned this May 29, 2019
@sdeleuze sdeleuze added the in: web Issues in web modules (web, webmvc, webflux, websocket) label May 29, 2019
@sdeleuze sdeleuze closed this in 4523d01 May 29, 2019
@sdeleuze
Copy link
Contributor

Thanks for spotting this, I fixed it by using put instead as suggested by @poutsma since HttpHeaders is also a Map<String, List<String>>.

@izeye izeye deleted the polish-20190529 branch May 29, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sdeleuze sdeleuze

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket)
Projects
None yet
Milestone
5.1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@izeye @sdeleuze @spring-projects-issues