Use Math.min() in ExponentialBackOff #25381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calculated by means of Math.max() or Math.min() instead of doing it manually.
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: core
sbrannen
reviewed
Jul 13, 2020
| @@ -354,7 +354,7 @@ public ByteVector putByteArray( | |||
| private void enlarge(final int size) { | |||
| int doubleCapacity = 2 * data.length; | |||
| int minimalCapacity = length + size; | |||
| byte[] newData = new byte[doubleCapacity > minimalCapacity ? doubleCapacity : minimalCapacity]; | |||
| byte[] newData = new byte[Math.max(doubleCapacity, minimalCapacity)]; | |||
There was a problem hiding this comment.
Please refrain from modifying classes under org.springframework.asm, org.springframework.cglib, and org.springframework.objenesis. Those include repackaged forks of the third-party libraries ASM, CGLIB, and Objenesis. Any refactoring to those classes should take place upstream in the originating repository. The Spring Framework will then pick up the changes when syncing with official updates of the forked third-party libraries.
Note, however, that there is no need to update this PR. I'll simply revert that before merging.
sbrannen
removed
the
status: waiting-for-triage
sbrannen
changed the title
|
This has been revised and merged into Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports cases where the minimum or the maximum of two numbers can be calculated by means of Math.max() or Math.min() instead of doing it manually.