Skip to content

Use System.currentTimeMillis() in AbstractSockJsService #25447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Use System.currentTimeMillis() in AbstractSockJsService #25447

merged 1 commit into from
Jul 22, 2020

Conversation

XenoAmess
Copy link
Contributor

as title

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 21, 2020
@sbrannen
Copy link
Member

Can you please briefly explain the rationale for the proposed change?

@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 21, 2020
@sbrannen sbrannen changed the title use System.currentTimeMillis Use System.currentTimeMillis() in AbstractSockJsService Jul 21, 2020
@XenoAmess
Copy link
Contributor Author

Can you please briefly explain the rationale for the proposed change?

@sbrannen https://stackoverflow.com/questions/368094/system-currenttimemillis-vs-new-date-vs-calendar-getinstance-gettime

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jul 22, 2020
@XenoAmess
Copy link
Contributor Author

image

@sbrannen sbrannen added the type: enhancement A general enhancement label Jul 22, 2020
@sbrannen sbrannen self-assigned this Jul 22, 2020
@sbrannen sbrannen added this to the 5.3 M2 milestone Jul 22, 2020
@sbrannen sbrannen merged commit e4a139e into spring-projects:master Jul 22, 2020
@sbrannen
Copy link
Member

This has been merged into master.

Thanks for the PR and for providing the rationale.

@sbrannen
Copy link
Member

In future PRs, please make sure to delete unused imports (see 24f9b1d) and run ./gradlew check before submitting the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: feedback-provided Feedback has been provided type: enhancement A general enhancement
Projects
None yet
Milestone
5.3 M2
Development

Successfully merging this pull request may close these issues.
3 participants
@XenoAmess @sbrannen @spring-projects-issues