Skip to content

Use private static instead of static private for method declarations #25452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

Use private static instead of static private for method declarations #25452

merged 1 commit into from
Jul 21, 2020

Conversation

XenoAmess
Copy link
Contributor

as title

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 21, 2020
@sbrannen sbrannen self-assigned this Jul 21, 2020
@sbrannen sbrannen added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 21, 2020
@sbrannen sbrannen changed the title change static private to private static Use static private instead of private static for method declarations Jul 21, 2020
@sbrannen sbrannen added this to the 5.3 M2 milestone Jul 21, 2020
@sbrannen sbrannen merged commit e71f702 into spring-projects:master Jul 21, 2020
@sbrannen
Copy link
Member

This has been merged into master.

Thanks

@izeye
Copy link
Contributor

izeye commented Jul 27, 2020

The title seems to be the opposite to what has been done.

@sbrannen
Copy link
Member

The title seems to be the opposite to what has been done.

Indeed. That was my mistake when I reworded this PR's title incorrectly. I'll fix it now, but the associated commit message will unfortunately remain misleading.

@sbrannen sbrannen changed the title Use static private instead of private static for method declarations Use private static instead of static private for method declarations Jul 27, 2020
@XenoAmess
Copy link
Contributor Author

The title seems to be the opposite to what has been done.

Indeed. That was my mistake when I reworded this PR's title incorrectly. I'll fix it now, but the associated commit message will unfortunately remain misleading.

@sbrannen @izeye
Sorry for the mistake I made in commit message, and the delay of reply.

@sbrannen
Copy link
Member

The title seems to be the opposite to what has been done.

Indeed. That was my mistake when I reworded this PR's title incorrectly. I'll fix it now, but the associated commit message will unfortunately remain misleading.

@sbrannen @izeye
Sorry for the mistake I made in commit message, and the delay of reply.

No worries. It was I who made the mistake in the commit message anyway. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
type: task A general task
Projects
None yet
Milestone
5.3 M2
Development

Successfully merging this pull request may close these issues.
4 participants
@XenoAmess @sbrannen @izeye @spring-projects-issues