Add maxAttempts to ExponentialBackOff #27071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you wish to stop after a certain number of attempts with an `ExponentialBackOff` you have to calculate the `maxElapsedTime` corresponding to the number of attempts. See https://github.com/spring-projects/spring-kafka/blob/0ee2d49ea525de038d315bc243b62f1004a26dc6/spring-kafka/src/main/java/org/springframework/kafka/support/ExponentialBackOffWithMaxRetries.java#L74-L84 Add a new property to make it more convenient to stop after a certain number of attempts.
spring-projects-issues
added
the
status: waiting-for-triage
artembilan
suggested changes
Jun 16, 2021
There was a problem hiding this comment.
A couple Checkstyle issues:
[ant:checkstyle] [ERROR] /tmp/build/f663b219/git-repo/spring-core/src/main/java/org/springframework/util/backoff/ExponentialBackOff.java:79:9: Missing a Javadoc comment. [JavadocVariable]
[ant:checkstyle] [ERROR] /tmp/build/f663b219/git-repo/spring-core/src/main/java/org/springframework/util/backoff/ExponentialBackOff.java:195:24: Reference to instance variable 'maxAttempts' needs "this.". [RequireThis]
See Concourse CI report for PR.
| * The maximum number of attempts after which a call to | ||
| * {@link BackOffExecution#nextBackOff()} returns {@link BackOffExecution#STOP}. | ||
| * @param maxAttempts the maxAttempts. | ||
| * @see #setMaxElapsedTime(long) |
There was a problem hiding this comment.
Probably some @since has to be here on public API.
Let's start from the current one and we'll see how this PR going to be approved!
rstoyanchev
added
the
in: core
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Aug 26, 2023
If you wish to stop after a certain number of attempts with an `ExponentialBackOff` you have to calculate the `maxElapsedTime` corresponding to the number of attempts. Add a new property to make it more convenient to stop after a certain number of attempts. See gh-27071
snicoll
added a commit
that referenced
this pull request
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you wish to stop after a certain number of attempts with an
ExponentialBackOffyou have to calculate themaxElapsedTimecorresponding to the number of attempts.
See https://github.com/spring-projects/spring-kafka/blob/0ee2d49ea525de038d315bc243b62f1004a26dc6/spring-kafka/src/main/java/org/springframework/kafka/support/ExponentialBackOffWithMaxRetries.java#L74-L84
Add a new property to make it more convenient to stop after a
certain number of attempts.