Support CBOR and Protobuf with Kotlin Serialization #27628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass hierarchy. Kotlin Serialization has two primary types of serialization, Binary and String. JSON Kotlin Serialization uses kotlinx.serialization.StringFormat. This class hierarchy treats the Kotlin Serialization JSON classes as concrete implementations of less specific Kotlin Serialization String classes.
…l Buffer serialization Add Kotlin Serialization Binary classes necessary to implement CBOR and Protocol Buffer encoders, decoders, and converters. Update automatic configuration to utilize these classes if the necessary dependencies are on the classpath.
|
@iain-henderson Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@iain-henderson Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
the
in: web
|
Conflicts are caused by using constants for MediaTypes. With more input from the project owners, I'm willing to fix it. |
poutsma
removed
the
status: waiting-for-triage
|
Thank you for submitting a PR, @iain-henderson. After making some changes, I have merged it in b8243e6. |
poutsma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Spring only had built in support for Kotlin Serializations to/from JSON, but that the existing implementation for Kotlin Serialization of JSON was mostly sufficient for a more general implementation.
With a few modifications Spring gains support for Kotlin Serialization to CBOR and Protocol Buffers AND the ability to manually configure other Kotlin Serialization types.