Fix SpEL propertyReadWriteWithRootObject() test #27905
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially modify PropertyAccessTests#propertyReadWriteWithRootObject. The test case is for method 'withRootObject' but actually it's copied for the previous case.
spring-projects-issues
added
the
status: waiting-for-triage
|
Good catch. That test method is indeed not testing what it's intended to. And congratulations on submitting your first PR to the Spring Framework! 👍 |
sbrannen
added
in: core
sbrannen
changed the title
|
This has been merged into Thanks As a side note, your fix made me notice a similar issue in another test method in that class, which I fixed in 59c6b7e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially modify PropertyAccessTests#propertyReadWriteWithRootObject.
The test case is for method 'withRootObject' but actually it's copied
for the previous case.