Skip to content

Optimize SpEL and property placeholder support for @Async qualifiers #28549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Optimize SpEL and property placeholder support for @Async qualifiers #28549

wants to merge 3 commits into from

Conversation

dawn9117
Copy link
Contributor

@dawn9117 dawn9117 commented May 31, 2022 •
edited
Loading

optimize spel in AsyncExecutionAspectSupport

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 31, 2022
@quaff
Copy link
Contributor

quaff commented Jun 1, 2022

spel is already supported.

@dawn9117
Copy link
Contributor Author

dawn9117 commented Jun 1, 2022 •
edited by sbrannen
Loading

spel is already supported.

Okay, but use cases like @Async("${executor.name:}") don't work when executor.name is not configured.

Additionally EmbeddedValueResolver can be reused.

@dawn9117 dawn9117 changed the title support spel in AsyncExecutionAspectSupport optimize spel in AsyncExecutionAspectSupport Jun 1, 2022
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Jun 1, 2022
@sbrannen sbrannen changed the title optimize spel in AsyncExecutionAspectSupport Optimize SpEL and property placeholder support for @Async qualifiers Jun 1, 2022
@sbrannen
Copy link
Member

sbrannen commented Jun 1, 2022

Related Issues

@sbrannen sbrannen self-assigned this Jun 1, 2022
@sbrannen sbrannen added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 1, 2022
sbrannen
sbrannen requested changes Jun 1, 2022
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested change and introduce a test that fails before this PR and passes after this PR.

@sbrannen sbrannen added this to the 6.0.0-M5 milestone Jun 1, 2022
@dawn9117 dawn9117 requested a review from sbrannen June 2, 2022 02:33
@dawn9117 dawn9117 marked this pull request as draft June 3, 2022 05:15
@dawn9117 dawn9117 marked this pull request as ready for review June 3, 2022 05:17
@dawn9117
Copy link
Contributor Author

dawn9117 commented Jun 4, 2022

Please make the requested change and introduce a test that fails before this PR and passes after this PR.

I've already added it. Please review, thanks.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 4, 2022
@sbrannen sbrannen modified the milestones: 6.0.0-M5, 6.0.0-M6 Jun 20, 2022
@sbrannen sbrannen modified the milestones: 6.0.0-M6, 6.0.0-RC1 Aug 29, 2022
@sbrannen
Copy link
Member

sbrannen commented Oct 5, 2022

I've already added it. Please review, thanks.

Thanks for making the requested changes. I'll see about getting it merged in.

@sbrannen sbrannen removed the status: feedback-provided Feedback has been provided label Oct 5, 2022
@sbrannen sbrannen closed this in 2434470 Oct 7, 2022
sbrannen added a commit that referenced this pull request Oct 7, 2022
@sbrannen
Polish contribution
72307bb 
See gh-28549
@sbrannen
Copy link
Member

sbrannen commented Oct 7, 2022

This has been merged into main.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@dawn9117 @quaff @sbrannen @spring-projects-issues