Fix link to WebFlux section in reference manual #29525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
type: documentation
sbrannen
changed the title
sbrannen
reviewed
Nov 19, 2022
| @@ -6,7 +6,7 @@ include::page-layout.adoc[] | |||
| This part of the documentation covers support for reactive-stack web applications built | |||
| on a https://www.reactive-streams.org/[Reactive Streams] API to run on non-blocking | |||
| servers, such as Netty, Undertow, and Servlet containers. Individual chapters cover | |||
| the <<webflux.adoc#webflux, Spring WebFlux>> framework, | |||
| the <<web/webflux.adoc#webflux, Spring WebFlux>> framework, | |||
There was a problem hiding this comment.
Suggested change
| the <<web/webflux.adoc#webflux, Spring WebFlux>> framework, | |
| the <<webflux, Spring WebFlux>> framework, |
Your fix works; however, when cross referencing a section within the current file (after includes have been applied), there is no need to use the folder and file name.
I'll simplify that when merging the PR.
There was a problem hiding this comment.
Thanks for your review.
sbrannen
added
status: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Web on Reactive Stact, the link to the webflux chapter in the firxt paragraph is broken.
This link will take you to 404 page.
(This is similar to #29513)
So I Fix the link in this PR.
Please review and let me know if I misunderstood.