-
Notifications
You must be signed in to change notification settings - Fork 38.5k
Extract ResourceEntityResolver HTTPS schema resolution fallback #29697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract ResourceEntityResolver HTTPS schema resolution fallback #29697
Conversation
This commit extracts the DTD/XSD remote lookup fallback from the resolveEntity method into a protected method. A warn logging statement is added to the extracted fallback in order to make it clear that remote lookup happened. Overriding the protected method would allow users to avoid this fallback entirely if it isn't desirable, without the need to duplicate the local resolution code. Fixes spring-projectsgh-29662.
|
Refer to the EntityResolver's resolveEntity semantics as a reference perhaps? That's ultimately what you're triggering. |
Returning Throwing an exception should cause the parser to fail (and skip any attempt to load the remote resource). We should introduce tests for both use cases. |
This commit extracts the DTD/XSD remote lookup fallback from the
resolveEntity method into a protected method.
A warn logging statement is added to the extracted fallback in order to
make it clear that remote lookup happened.
Overriding the protected method would allow users to avoid this fallback
entirely if it isn't desirable, without the need to duplicate the local
resolution code.
Fixes gh-29662.