Replace switch statements with enhanced switch statements for consistency #30283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
requested changes
Apr 5, 2023
There was a problem hiding this comment.
Please refrain from modifying classes under org.springframework.asm and org.springframework.objenesis. Those include repackaged forks of the third-party libraries ASM and Objenesis. Any refactoring to those classes should take place upstream in the originating repository. The Spring Framework will then pick up the changes when syncing with official updates of the forked third-party libraries.
In light of that, please revert changes to ASM source code.
sbrannen
added
status: waiting-for-feedback
sbrannen
removed
status: waiting-for-feedback
sbrannen
approved these changes
Apr 5, 2023
|
@sbrannen When can this code be merged? |
|
Hi @ssang1105,
I apologize: I had forgotten about this PR. I'll take another look. |
|
This has been merged into Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve code consistency and readability by updating existing switch statements to use the enhanced switch syntax. The changes have been made only in classes where: