Skip to content

Fix link in Javadoc of PassThroughFilterChain #30365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2023
Merged

Fix link in Javadoc of PassThroughFilterChain #30365

merged 1 commit into from
Apr 23, 2023

Conversation

kzander91
Copy link
Contributor

@kzander91 kzander91 commented Apr 23, 2023 •
edited
Loading

The Javadoc in PassThroughFilterChain incorrectly says that it implements FilterConfig, when in fact it implements FilterChain.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 23, 2023
@kzander91 kzander91 mentioned this pull request Apr 23, 2023
Closed
@kzander91 kzander91 force-pushed the passthrough-filter-chain-javadoc-fix branch from 0701aac to 930bbd7 Compare April 23, 2023 10:53
@sbrannen sbrannen self-assigned this Apr 23, 2023
@sbrannen sbrannen added in: test Issues in the test module type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 23, 2023
@sbrannen sbrannen added this to the 6.1.0-M1 milestone Apr 23, 2023
@sbrannen sbrannen merged commit 5b2aa0b into spring-projects:main Apr 23, 2023
@sbrannen
Copy link
Member

This has been merged into main.

Thanks

And... thanks for updating the "test fixture" copy as well. 👍

@kzander91 kzander91 deleted the passthrough-filter-chain-javadoc-fix branch April 23, 2023 14:11
@sbrannen sbrannen changed the title Fix @link in Javadoc of PassThroughFilterChain Fix link in Javadoc of PassThroughFilterChain Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Milestone
6.1.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@kzander91 @sbrannen @spring-projects-issues