Replace deprecated references in WebSocketMessageBrokerStats.toString() #33543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: web
rstoyanchev
reviewed
Sep 26, 2024
There was a problem hiding this comment.
The only potential issue is if those methods are overridden by a sub-class, or if the corresponding info methods on the component providing the stats is overridden. Granted that seems unlikely, but do you see any harm in leaving toString as is for the time being?
rstoyanchev
added
the
status: waiting-for-feedback
|
@rstoyanchev No, I just wanted to clean up the deprecated references. |
spring-projects-issues
added
status: feedback-provided
|
Okay, thanks for the suggestion. We can defer that until the deprecations are removed since it is internal only. |
rstoyanchev
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces deprecated references in the
WebSocketMessageBrokerStats.toString().