Skip to content

Add property accessors to ExecutorConfigurationSupport #34034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

lucky8987
Copy link
Contributor

@lucky8987 lucky8987 commented Dec 5, 2024

Sometimes I need to check if the ExecutorConfigurationSupport executor has enabled virtual threads, so I added the corresponding getter methods.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 5, 2024
@snicoll
Copy link
Member

snicoll commented Dec 6, 2024

Sometimes I need to check if the ExecutorStructureSupport executor has enabled virtual threads,

Why is that? And why do you need the bean's name?

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Dec 6, 2024
@sbrannen sbrannen changed the title Add get functions to ExecutorFigurationSupport Add property accessors to ExecutorConfigurationSupport. Dec 6, 2024
@sbrannen sbrannen changed the title Add property accessors to ExecutorConfigurationSupport. Add property accessors to ExecutorConfigurationSupport Dec 6, 2024
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Dec 6, 2024
@lucky8987
Copy link
Contributor Author

Sometimes I need to check if the ExecutorStructureSupport executor has enabled virtual threads,

Why is that? And why do you need the bean's name?

Because I want to print executor related information on the actuator endpoint, I need to obtain beanName as the key. Of course, this is not necessary, and I can also obtain it through other means.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 6, 2024
@snicoll
Copy link
Member

snicoll commented Dec 30, 2024

@lucky8987 you need to reset your "dev" branch to what you intend to submit in this PR. Right now there are a number of unrelated commits in it.

@lucky8987
Copy link
Contributor Author

lucky8987 commented Dec 31, 2024

@lucky8987 you need to reset your "dev" branch to what you intend to submit in this PR. Right now there are a number of unrelated commits in it.

Sorry, my other change should not have been submitted here. I have now reset this branch and I really hope that this PR can be merged.

@snicoll
Copy link
Member

snicoll commented Feb 4, 2025

Thanks for the suggestion but the flag is a configuration shortcut to enable VT. We can't ensure it has the parity that you expect (i.e. it's not reliable to rely on the internal boolean flag to determine that VT is enabled).

@snicoll snicoll closed this Feb 4, 2025
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on status: feedback-provided Feedback has been provided labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants