Move Micrometer instrumentation to this project #501
Assignees
Labels
Milestone
Comments
bclozel
added
type: enhancement
This was referenced Oct 17, 2022
bclozel
added a commit
to spring-projects/spring-boot
that referenced
this issue
Oct 19, 2022
This commit migrates the existing metrics support (added in #29140) to the new `Observation` instrumentation contributed in spring-projects/spring-graphql#501. We cannot have a smoother migration path here as the instrumentation does not use the same context information for metadata extraction. Closes gh-32794
koenpunt
pushed a commit
to koenpunt/spring-graphql
that referenced
this issue
Feb 2, 2023
Prior to this commit, metrics instrumentation was provided by Spring Boot, using Micrometer metrics. The `Instrumentation` would publish two timers and a counter, but would not support tracing. This commit replaces the former with a dedicated support in Spring for GraphQL directly. This uses the new `Observation` API from Micrometer and publishes two observations: * a request execution observation, with timing and tracing included * a data fetching observation with the request execution as a parent observation Closes spring-projectsgh-501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the new Micrometer 1.10 Observation API, we need to move the existing metrics instrumentation from Spring Boot to this project and use the
ObservationAPI instead. This needs to happen before #469.The text was updated successfully, but these errors were encountered: