Skip to content

Observation Instrumentation will double-wrap CompletionExceptions #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions bot opened this issue Aug 28, 2023 · 1 comment
Closed

Observation Instrumentation will double-wrap CompletionExceptions #784

github-actions bot opened this issue Aug 28, 2023 · 1 comment
Assignees
@bclozel
Labels
in: core Issues related to config and core support type: backport type: bug A general bug
Milestone
1.1.6

Comments

@github-actions
Copy link
Contributor

Backport of gh-780
@github-actions github-actions bot added in: core Issues related to config and core support type: backport type: bug A general bug labels Aug 28, 2023
@github-actions github-actions bot added this to the 1.1.6 milestone Aug 28, 2023
@bclozel bclozel self-assigned this Aug 28, 2023
bclozel added a commit that referenced this issue Aug 28, 2023
@bclozel
Do not rewrap CompletionException in DataFetcher instrumentation
9b61d28 
This commit ensures that, when an instrumented DataFetcher returns a
`CompletionException`, we do not re-wrap it with the same exception
type. This aligns with the behavior enforced in the JDK
`CompletableFuture`.

Fixes gh-784
@github-actions
Copy link
Contributor Author

Fixed via 9b61d28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: core Issues related to config and core support type: backport type: bug A general bug
Projects
None yet
Milestone
1.1.6
Development

No branches or pull requests
1 participant
@bclozel