Lenient parsing of SourceLocation's line and column in ResponseMapGraphQlResponse #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Stmated Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Stmated Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
type: enhancement
rstoyanchev
changed the title
rstoyanchev
pushed a commit
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the registered
ObjectMapperhas enabledDeserializationFeature.USE_BIG_INTEGER_FOR_INTSthen the response parsing fails because it assumesint.This checks the field type and converts appropriately, and falls back to
-1if it is not a number. This might not be the wanted way of handling the fallback. Maybe an exception should be thrown?