Add MQTT5 sample application with integration flows and tests #365
Conversation
Signed-off-by: Minyoung Noh <[email protected]> spring-projects#323
| @@ -0,0 +1,24 @@ | |||
| <configuration> | |||
There was a problem hiding this comment.
Why are you using the logback configuration here?
There was a problem hiding this comment.
@cppwfs Is it better to delete the logback configuration?
There was a problem hiding this comment.
It can be removed unless there is a particular reason it is needed.
| * @since 5.2 | ||
| * | ||
| */ | ||
| public class BrokerRunning extends TestWatcher { |
There was a problem hiding this comment.
Please remove BrokerRunning as the method for testing the MQTT5 app. Please use the Mosquitto test container as shown here: https://github.com/spring-projects/spring-integration/blob/main/spring-integration-mqtt/src/test/java/org/springframework/integration/mqtt/MqttDslTests.java
| @Bean | ||
| public MqttConnectionOptions mqttConnectionOptions() { | ||
| MqttConnectionOptions options = new MqttConnectionOptions(); | ||
| options.setServerURIs(new String[]{ "tcp://localhost:1883" }); |
There was a problem hiding this comment.
You will need expose host and port with either ConfigurationProperties or SystemProperties instead of the hardcoded value. Especially when using test container because they use dynamic properties to establish ports.
Signed-off-by: nmy6452 <[email protected]>
Signed-off-by: nmy6452 <[email protected]>
Signed-off-by: nmy6452 <[email protected]>
Signed-off-by: Minyoung Noh [email protected]
Create PR for #323 issues.
I worked on the PR base that was rejected before, please refer to it and review it. #364