Skip to content

IntegrationFlowContext.getRegistrationById(String flowId) should be marked as @Nullable #8750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mrpiggi opened this issue Oct 8, 2023 · 2 comments · Fixed by #8753
Closed

IntegrationFlowContext.getRegistrationById(String flowId) should be marked as @Nullable #8750

mrpiggi opened this issue Oct 8, 2023 · 2 comments · Fixed by #8753
Labels
(EOL) for: backport-to-6.1.x in: dsl type: bug
Milestone
6.2.0-RC1

Comments

@mrpiggi
Copy link
Contributor

mrpiggi commented Oct 8, 2023

...as it is part of @NonNullApi

spring-integration/spring-integration-core/src/main/java/org/springframework/integration/dsl/context/IntegrationFlowContext.java

Lines 66 to 74 in ad01c44

/**
* Obtain an {@link IntegrationFlowRegistration} for the {@link IntegrationFlow}
* associated with the provided {@code flowId}.
* @param flowId the bean name to obtain
* @return the IntegrationFlowRegistration for provided {@code id} or {@code null}
*/
IntegrationFlowRegistration getRegistrationById(String flowId);

@artembilan
Copy link
Member

Confirmed.

Please, consider to contribute such a simple fix: https://github.com/spring-projects/spring-integration/blob/main/CONTRIBUTING.adoc

Thanks

@artembilan artembilan added this to the 6.2.0-RC1 milestone Oct 9, 2023
@mrpiggi mrpiggi mentioned this issue Oct 9, 2023
Merged
@mrpiggi
Copy link
Contributor Author

mrpiggi commented Oct 9, 2023

Actually, as it is such a simple fix I was not keen to setup a clone for myself. Nevertheless, here you are.

artembilan pushed a commit that referenced this issue Oct 10, 2023
@mrpiggi
GH-8750: Add @Nullable to getRegistrationById()
49cd14c 
Fixes #8750

* annotate `IntegrationFlowRegistration.getRegistrationById(String flowId)` with `@org.springframework.lang.Nullable`
* annotate `StandardIntegrationFlowContext.getRegistrationById(String flowId)` with `@org.springframework.lang.Nullable`

**Cherry-pick to `6.1.x` & `6.0.x`**
artembilan pushed a commit that referenced this issue Oct 10, 2023
@mrpiggi @artembilan
GH-8750: Add @Nullable to getRegistrationById()
b456fe6 
Fixes #8750

* annotate `IntegrationFlowRegistration.getRegistrationById(String flowId)` with `@org.springframework.lang.Nullable`
* annotate `StandardIntegrationFlowContext.getRegistrationById(String flowId)` with `@org.springframework.lang.Nullable`

**Cherry-pick to `6.1.x` & `6.0.x`**

(cherry picked from commit 49cd14c)
artembilan pushed a commit that referenced this issue Oct 10, 2023
@mrpiggi @artembilan
GH-8750: Add @Nullable to getRegistrationById()
680acfb 
Fixes #8750

* annotate `IntegrationFlowRegistration.getRegistrationById(String flowId)` with `@org.springframework.lang.Nullable`
* annotate `StandardIntegrationFlowContext.getRegistrationById(String flowId)` with `@org.springframework.lang.Nullable`

**Cherry-pick to `6.1.x` & `6.0.x`**

(cherry picked from commit 49cd14c)
@mrpiggi mrpiggi mentioned this issue Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
(EOL) for: backport-to-6.1.x in: dsl type: bug
Projects
None yet
Milestone
6.2.0-RC1
Development

Successfully merging a pull request may close this issue.

GH-8750: mark getRegistrationById() as @Nullable
2 participants
@artembilan @mrpiggi