GH-3334: Add "embedded reaper" into CorrelationMH #3342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is OK, I'll go ahead with Java DSL and XML options. |
garyrussell
suggested changes
Jul 16, 2020
Comment on lines
88
to
91
| * When the {@link #expireTimeout} is more than 0, the groups which older then this timeout | ||
| * is purged from the store on start up (or when {@link #purgeOrphanedGroups()} is called). | ||
| * If {@link #expireDuration} is provide, the task is scheduled to perform | ||
| * {@link #purgeOrphanedGroups()} periodically. |
There was a problem hiding this comment.
Suggested change
| * When the {@link #expireTimeout} is more than 0, the groups which older then this timeout | |
| * is purged from the store on start up (or when {@link #purgeOrphanedGroups()} is called). | |
| * If {@link #expireDuration} is provide, the task is scheduled to perform | |
| * {@link #purgeOrphanedGroups()} periodically. | |
| * When the {@link #expireTimeout} is greater than 0, groups which are older than this timeout | |
| * are purged from the store on start up (or when {@link #purgeOrphanedGroups()} is called). | |
| * If {@link #expireDuration} is provides, the task is scheduled to perform | |
| * {@link #purgeOrphanedGroups()} periodically. |
Comment on lines
327
to
330
| * Used on startup and if {@link #expireDuration} is provided the task for {@link #purgeOrphanedGroups()} | ||
| * is scheduled with that period. | ||
| * The {@link #forceReleaseProcessor} is used to process those expired groups according | ||
| * the "force complete" options. |
There was a problem hiding this comment.
Suggested change
| * Used on startup and if {@link #expireDuration} is provided the task for {@link #purgeOrphanedGroups()} | |
| * is scheduled with that period. | |
| * The {@link #forceReleaseProcessor} is used to process those expired groups according | |
| * the "force complete" options. | |
| * Used on startup and when an {@link #expireDuration} is provided, the task for running | |
| * {@link #purgeOrphanedGroups()} is scheduled with that period. | |
| * The {@link #forceReleaseProcessor} is used to process those expired groups according | |
| * the "force complete" options. A group can be orphaned if a persistent message group | |
| * store is used and no new messages arrive for that group after a restart. |
Fixes spring-projects#3334 * Add `expireTimeout` property into `AbstractCorrelatingMessageHandler` to call newly introduced `purgeOrphanedGroups()` API for removing old groups from the store * Add `expireDuration` to perform `purgeOrphanedGroups()` task periodically
…n` options * Document the new feature
garyrussell
suggested changes
Jul 20, 2020
.../main/java/org/springframework/integration/aggregator/AbstractCorrelatingMessageHandler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Gary Russell <[email protected]>
|
Some problem with Flux aggregator test in travis - maybe not related but suspicious given this code is in the aggregator. |
|
No, not related. I so it failing here on Travis before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3334
expireTimeoutproperty intoAbstractCorrelatingMessageHandlerto call newly introduced
purgeOrphanedGroups()API for removing oldgroups from the store
expireDurationto performpurgeOrphanedGroups()task periodically