-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add documentation for Observability #3896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42ae292
to
af575ad
Compare
onobc
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am glad I saw this PR. It has a couple of things I can leverage in spring-pulsar
- thanks for that.
- The removal of package tangles
- The package/name reduction to
o.s.i
for the generated docs
LGTM.
build.gradle
Outdated
@@ -84,8 +87,8 @@ ext { | |||
lettuceVersion = '6.2.0.RELEASE' | |||
log4jVersion = '2.19.0' | |||
mailVersion = '2.0.1' | |||
micrometerVersion = '1.10.0-M6' | |||
micrometerTracingVersion = '1.0.0-M8' | |||
micrometerVersion = '1.10.0-SNAPSHOT' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TinyNit] indentation
artembilan
commented
Sep 30, 2022
artembilan
commented
Sep 30, 2022
* Adapt Observation code to the latest dependencies * Add doc generation tasks for meters and spans * Document new Observation API features * Include generated meters and spans docs to a general `metrics.adoc` chapter
…t `SpansAssert` API
* Make Observation doc generation tasks only as local. We don't need ambiguous changes to source code on CI
…ld phase * Replace 'org.springframework.integration' content in the generated files with a 'o.s.i' to make it easier to read, especially in the tables * Break `DefaultMessageReceiverObservationConvention <=> IntegrationObservation` classes tangle using literal for `KeyValues` in the `DefaultMessageReceiverObservationConvention` instead of nested enums from the `IntegrationObservation` * Some other minor build script clean up
e34530f
to
bfb54f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metrics.adoc
chapter