Skip to content

Consider a Fatal Consumer Exception as an abnormal termination for a container #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Rajh opened this issue Mar 28, 2022 · 0 comments · Fixed by #2202
Closed

Consider a Fatal Consumer Exception as an abnormal termination for a container #2197

Rajh opened this issue Mar 28, 2022 · 0 comments · Fixed by #2202
Assignees
@garyrussell
Labels
backport 2.8.x (obsolete) type: enhancement
Milestone
3.0.0-M4

Comments

@Rajh
Copy link

Rajh commented Mar 28, 2022 •
edited
Loading

Expected Behavior

When there is an exception in a consumer like ACLs :
Authentication/Authorization Exception and no authExceptionRetryInterval set the container should be terminated abnormally.
The Container should report isInExpectedState() as false

Current Behavior

Currently, there is a log Fatal consumer exception; stopping container and then the container is stopped normally.
github code
@garyrussell garyrussell added this to the 3.0.0-M4 milestone Mar 28, 2022
@garyrussell garyrussell self-assigned this Mar 31, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 31, 2022
@garyrussell
spring-projectsGH-2197: Fix Container State After Fatal Stop
77eca37 
Resolves spring-projects#2197

When a container is stopped due to any fatal error, `isInExpectedState()`
should return false.

**cherry-pick to 2.8.x, 2.7.x**
@garyrussell garyrussell mentioned this issue Mar 31, 2022
Merged
artembilan pushed a commit that referenced this issue Mar 31, 2022
@garyrussell @artembilan
GH-2197: Fix Container State After Fatal Stop
6022835 
Resolves #2197

When a container is stopped due to any fatal error, `isInExpectedState()`
should return false.

**cherry-pick to 2.8.x, 2.7.x**
artembilan pushed a commit that referenced this issue Mar 31, 2022
@garyrussell @artembilan
GH-2197: Fix Container State After Fatal Stop
fea221f 
Resolves #2197

When a container is stopped due to any fatal error, `isInExpectedState()`
should return false.

**cherry-pick to 2.8.x, 2.7.x**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
backport 2.8.x (obsolete) type: enhancement
Projects
None yet
Milestone
3.0.0-M4
Development

Successfully merging a pull request may close this issue.

GH-2197: Fix Container State After Fatal Stop garyrussell/spring-kafka
2 participants
@Rajh @garyrussell