Add getEndOffsets() to KafkaTestUtils #1666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**cherry-pick to 2.6.x**
artembilan
requested changes
Jan 4, 2021
| .collect(Collectors.toList()); | ||
| } | ||
| else { | ||
| Assert.noNullElements(partitions, "'partitions' cannot have nulll elements"); |
There was a problem hiding this comment.
Typo:
Suggested change
| Assert.noNullElements(partitions, "'partitions' cannot have nulll elements"); | |
| Assert.noNullElements(partitions, "'partitions' cannot have null elements"); |
| * @param topic the topic. | ||
| * @param partitions the partitions, or null for all partitions. | ||
| * @return the map of end offsets. | ||
| * @since 2.6.5 |
There was a problem hiding this comment.
We probably need to add a @see for JavaDocs of that consumer.endOffsets() because that is exactly an info we get back.
| * @return the map of end offsets. | ||
| * @since 2.6.5 | ||
| */ | ||
| public static <K, V> Map<TopicPartition, Long> getEndOffsets(Consumer<K, V> consumer, String topic, |
There was a problem hiding this comment.
I think these generic arguments don't give any value or benefits.
Probably Consumer<?, ?> is what would work for end-users. Even if we need to do some casting internally, it is not going to affect target applications.
|
... and cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick to 2.6.x