Skip to content

Mention spring-restdocs-webtestclient as an alternative dependency in getting started documentation #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

LichKing-lee
Copy link
Contributor

Add webtestclient in gradle

Add webtestclient in gradle
@pivotal-issuemaster
Copy link

@LichKing-lee Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@LichKing-lee Thank you for signing the Contributor License Agreement!

Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the PR, @LichKing-lee. I've left one comment for your consideration. Please let me know if you agree and if you have time to amend your pull request accordingly. If you don't have time, I can take care of it while merging.

<3> Add a dependency on `spring-restdocs-mockmvc` in the `testCompile` configuration. If
you want to use REST Assured rather than MockMvc, add a dependency on
`spring-restdocs-restassured` instead.
<3> Add a dependency on `spring-restdocs-mockmvc` in the `test` scope. If you want to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should stay as "testCompile configuration".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. fix with maven

@wilkinsona wilkinsona added type: documentation Changes to the documentation and removed status: waiting-for-triage Untriaged issue labels Oct 24, 2019
@wilkinsona wilkinsona added this to the 2.0.5.RELEASE milestone Oct 24, 2019
@@ -131,7 +131,7 @@ the configuration are described in the following listings:
</plugins>
</build>
----
<1> Add a dependency on `spring-restdocs-mockmvc` in the `test` scope. If you want to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should stay as "test scope" as it's Maven.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. i understand. my mistake sorry.

@wilkinsona
Copy link
Member

@LichKing-lee Thank you very much for making your first contribution to Spring REST Docs. The proposed changes have been merged into master.

@LichKing-lee LichKing-lee deleted the patch-1 branch October 24, 2019 09:24
@wilkinsona wilkinsona changed the title Update getting-started.adoc Mention spring-restdocs-webtestclient as an alternative dependency in getting started documentation Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants