-
Notifications
You must be signed in to change notification settings - Fork 737
Mention spring-restdocs-webtestclient as an alternative dependency in getting started documentation #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add webtestclient in gradle
@LichKing-lee Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@LichKing-lee Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the PR, @LichKing-lee. I've left one comment for your consideration. Please let me know if you agree and if you have time to amend your pull request accordingly. If you don't have time, I can take care of it while merging.
<3> Add a dependency on `spring-restdocs-mockmvc` in the `testCompile` configuration. If | ||
you want to use REST Assured rather than MockMvc, add a dependency on | ||
`spring-restdocs-restassured` instead. | ||
<3> Add a dependency on `spring-restdocs-mockmvc` in the `test` scope. If you want to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should stay as "testCompile
configuration".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. fix with maven
@@ -131,7 +131,7 @@ the configuration are described in the following listings: | |||
</plugins> | |||
</build> | |||
---- | |||
<1> Add a dependency on `spring-restdocs-mockmvc` in the `test` scope. If you want to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should stay as "test
scope" as it's Maven.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. i understand. my mistake sorry.
@LichKing-lee Thank you very much for making your first contribution to Spring REST Docs. The proposed changes have been merged into master. |
Add webtestclient in gradle