Skip to content

Set the useTrailingSlashMatch to true for tests #11462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

igorbolic
Copy link
Contributor

The Spring MVC changed the default behavior for trailing slash match
with spring-projects/spring-framework#28552.
This causes failures in Spring Security's tests.

Setting the useTrailingSlashMatch to true ensures that Spring
Security will work for users who have modified the default configuration.
Specifing the request mapper with trailing slash path ensures that the tests
are successful when default behavior is used.

Closes gh-11451

The Spring MVC changed the default behavior for trailing slash match
with spring-projects/spring-framework#28552.
This causes failures in Spring Security's tests.

Setting the `useTrailingSlashMatch` to `true` ensures that Spring
Security will work for users who have modified the default configuration.
Specifing the request mapper with trailing slash path ensures that the tests
are successful when default behavior is used.

Closes spring-projectsgh-11451
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 4, 2022
@jzheaux jzheaux self-assigned this Jul 5, 2022
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 5, 2022
@jzheaux jzheaux added this to the 6.0.0-M6 milestone Jul 5, 2022
@jzheaux jzheaux merged commit d96b4a0 into spring-projects:main Jul 5, 2022
@jzheaux
Copy link
Contributor

jzheaux commented Jul 5, 2022

Thanks, @igorbolic, this is now merged into main

@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Jul 5, 2022
@igorbolic igorbolic deleted the gh-11451 branch July 6, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServerJwtDslTests & WebTestClientHtmlUnitDriverBuilderTests tests failing with 404 issue
3 participants