Skip to content

Add @FunctionalInterface to AuthenticationManager #15379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Add @FunctionalInterface to AuthenticationManager #15379

wants to merge 0 commits into from

Conversation

pongdangx2
Copy link
Contributor

AuthgenticationManager Interface is being implemented by using lambda expression.
Therefore, It would be clear not to add more abstract function, If @FunctionalInterface annotation is added.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 8, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Jul 9, 2024

Thanks, @pongdangx2. Will you do me a favor and leave the copyright as-is? The Ageci copyright header is a special case.

@jzheaux jzheaux added in: cas An issue in spring-security-cas type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 9, 2024
@jzheaux jzheaux self-assigned this Jul 9, 2024
@pongdangx2
Copy link
Contributor Author

Thank you, @jzheaux I just restore the copyright line :)

@jzheaux
Copy link
Contributor

jzheaux commented Jul 12, 2024

@pongdangx2 will you please also squash your commits? This makes backporting simpler.

It would also be nice if the commit title were capitalized, like so:

Add @FunctionalInterface to AuthenticationManager

@pongdangx2
Copy link
Contributor Author

pongdangx2 commented Jul 13, 2024

@jzheaux
I rebase my commits. And another commit is created, that I didn't make. (commit 06a9227)

Could you please check if I should do something else??or I did right..?

@pongdangx2 pongdangx2 changed the title add FunctionalInterface annotation to AuthenticationManager Add @FunctionalInterface to AuthenticationManager Jul 15, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Jul 18, 2024

Thanks for hanging in there! For the rebase to work, @pongdangx2, you need to rebase to the most recent version of main.

It's easier to do this if you have a branch with your changes. So, first, I'd recommend doing the following:

git checkout -b authentication-manager-functional-interface
git checkout main

Now you have your changes saved to a separate branch and are back on main. Then, you will want to make your main up to date with the Spring Security upstream. For the following, imagine that the name you use locally for your fork is origin and the same of the Spring Security upstream is called spring-projects:

git fetch spring-projects
git reset --hard spring-projects/main
git push origin main

Now main on your fork should be the same as Spring Security. You can verify this by doing:

$> git status
...
Your branch is up to date with 'spring-projects/main'.

Having done this, you can rebase your branch and push it by doing:

git checkout authentication-manager-functional-interface
git rebase main
git push origin authentication-manager-functional-interface

Finally, close this PR and create a new one based on your branch.

While several steps, this approach will save you time later on as you will create a branch the moment you start a new feature or bug fix.

@jzheaux jzheaux added in: core An issue in spring-security-core and removed in: cas An issue in spring-security-cas labels Jul 18, 2024
@pongdangx2 pongdangx2 closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants