Replace deprecated #check calls with #authorize #16965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
...rc/main/java/org/springframework/security/authorization/ObservationAuthorizationManager.java
Show resolved
Hide resolved
|
Hey @evgeniycheban , It would be nice if the |
Yeah, good catch, I must have missed that one. |
jzheaux
added
in: core
jzheaux
requested changes
Apr 23, 2025
...st/java/org/springframework/security/authorization/ObservationAuthorizationManagerTests.java
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/authorization/ObservationAuthorizationManager.java
Show resolved
Hide resolved
Closes spring-projectsgh-16936 Signed-off-by: Evgeniy Cheban <[email protected]>
|
Hi, @jzheaux I've updated the PR. |
|
It would be nice to make the same improvement for |
|
Hi, @jzheaux @franticticktick I've added a new commit replacing |
evgeniycheban
force-pushed
the
gh-16936
branch
2 times, most recently
from
a191f9f to
8f2a6aa
Compare
…thorize Closes spring-projectsgh-16936 Signed-off-by: Evgeniy Cheban <[email protected]>
jzheaux
approved these changes
Jun 12, 2025
|
Thanks again, @evgeniycheban, also @franticticktick for your feedback. This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16936